Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community-features#252 Create static test for action controllers. #29339

Merged
merged 19 commits into from
Aug 20, 2020
Merged

community-features#252 Create static test for action controllers. #29339

merged 19 commits into from
Aug 20, 2020

Conversation

swnsma
Copy link
Contributor

@swnsma swnsma commented Jul 30, 2020

Description (*)

Introduce legacy test which prevent extend AbstractAction in new controller classes.

Fixed Issues

  1. Create static test for action controllers community-features#252

Manual testing scenarios (*)

  1. Add new controller class which extends Magento\Framework\App\Action\AbstractAction
  2. Runt test.
  3. Test should report an error.
  4. Test should report an error if class was added during development (by git diff).

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

community-features#252 Create static test for action controllers.
8f43c63 
Add Legacy test to check if newly created controllers do not extend AbstractAction.
@m2-assistant
Copy link

m2-assistant bot commented Jul 30, 2020

Hi @swnsma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Release Line: 2.4 Partner: Vaimo Pull Request is created by partner Vaimo partners-contribution Pull Request is created by Magento Partner labels Jul 30, 2020
@swnsma swnsma mentioned this pull request Jul 30, 2020
Closed
@swnsma swnsma requested review from lenaorobei and naydav July 30, 2020 20:06
@ghost ghost assigned kandy and ihor-sviziev Jul 30, 2020
@ihor-sviziev ihor-sviziev removed their assignment Jul 31, 2020
@swnsma
Copy link
Contributor Author

swnsma commented Jul 31, 2020

@magento run all tests

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ihor-sviziev ihor-sviziev self-assigned this Jul 31, 2020
@ihor-sviziev
Copy link
Contributor

@magento run all tests

lenaorobei
lenaorobei approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@ghost ghost assigned lenaorobei Jul 31, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-7927 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jul 31, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7927 has been created to process this Pull Request

@engcom-Kilo engcom-Kilo self-assigned this Aug 7, 2020
@sdzhepa sdzhepa added the Priority: P3 May be fixed according to the position in the backlog. label Aug 11, 2020
@engcom-Kilo
Copy link
Contributor

Tested with New Controller.

  1. Tested with Controller class that extend \Magento\Framework\App\Action\Action
  2. Tested with Controller class with implement \Magento\Framework\App\ActionInterface

Below added GIFs with tests, tests was running in PHPStorm.

test-red
test-green

@engcom-Kilo engcom-Kilo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Aug 14, 2020
@engcom-Kilo
Copy link
Contributor

@magento run all tests

@engcom-Kilo engcom-Kilo removed the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Aug 19, 2020
magento-engcom-team pushed a commit that referenced this pull request Aug 20, 2020
@sidolov
ENGCOM-7927: community-features#252 Create static test for action con…
81b42be 
…trollers. #29339
@magento-engcom-team magento-engcom-team merged commit 97be07f into magento:2.4-develop Aug 20, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 20, 2020

Hi @swnsma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ihor-sviziev ihor-sviziev mentioned this pull request Nov 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kandy kandy kandy left review comments

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@lenaorobei lenaorobei lenaorobei approved these changes

@naydav naydav Awaiting requested review from naydav

Assignees

@kandy kandy

@ihor-sviziev ihor-sviziev

@lenaorobei lenaorobei

@engcom-Kilo engcom-Kilo

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: advanced Award: test coverage Partner: Vaimo Pull Request is created by partner Vaimo partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@swnsma @ihor-sviziev @magento-engcom-team @lenaorobei @engcom-Kilo @kandy @sdzhepa